search

raycast / extensions

Everything you need to extend Raycast.
https://developers.raycast.com
MIT License
5.02k stars 2.75k forks source link

[Browser Bookmarks] Extension fav icons don't match browser fav icons #6590

Open charlesdurham opened 1 year ago

charlesdurham commented 1 year ago

Extension

https://www.raycast.com/raycast/browser-bookmarks

Description

The old (private) extension handled this nicely, I assume by reading from the browser's favicon DB instead of raycast's getFavIcon.

There are two main places where I've found getFavIcon to be worse than the (assumed) old approach.

  1. Urls behind authentication
  2. Url redirects

Steps To Reproduce

Use-case 1:

  1. Bookmark a url behind authentication (my repro case: https://[subdomain].atlassian.net)
  2. Search for the bookmark in the bookmark browser extension, the displayed icon is the fallback.

Use-case 2:

  1. Bookmark a url with a redirect (my repro case: https://mail.google.com)
  2. Search for the bookmark in the bookmark browser extension, the displayed icon is the fallback.

Current Behaviour

Icon displayed by bookmark browser extension is the fallback icon.

Expected Behaviour

Icon displayed by bookmark browser extension matches the fav icon in my browser.

raycastbot commented 1 year ago

Thank you for opening this issue!

🔔 @thomaslombart @sasivarnan you might want to have a look.

💡 Tip: Once the issue is resolved, comment @raycastbot close this issue to close it.

charlesdurham commented 1 year ago

In my limited test, using https://icon.horse/ was significantly better than https://www.google.com/s2/favicons. However it has the downside of not being free 😆

thomaslombart commented 1 year ago

Thanks for flagging this issue. Would you like to work on it? I can provide some guidance on how to contribute to this extension so that you can open a pull request. You can contact me here or in the Slack community if you need further help.

raycastbot commented 11 months ago

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊

raycastbot commented 11 months ago

This issue has been automatically closed due to inactivity.

Feel free to comment in the thread when you're ready to continue working on it 🙂

You can also catch us in Slack if you want to discuss this.

charlesdurham commented 9 months ago

@thomaslombart is this worth re-opening?

raycastbot commented 7 months ago

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊

raycastbot commented 5 months ago

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊

raycastbot commented 4 months ago

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊

raycastbot commented 1 month ago

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊