raycast / extensions

Everything you need to extend Raycast.
https://developers.raycast.com
MIT License
5.3k stars 2.98k forks source link

[Deepcast] Selected text as source doesn't seem to work #9077

Closed mattouzalem closed 11 months ago

mattouzalem commented 11 months ago

Extension

https://www.raycast.com/mooxl/deepcast

Description

Hey,

Even if I choose Selected as the Preferred Source in the extension settings, selected text doesn't appear in Deepcast. Please note that it's working well with other Raycast Extensions I use with this setting (WordReference, Quicklinks etc.).

Thanks a lot for the support!

Steps To Reproduce

  1. Select text
  2. Trigger Deepcast using a hotkey

Current Behaviour

No text appears in the extension.

Expected Behaviour

Selected text shall appear in the extension.

raycastbot commented 11 months ago

Thank you for opening this issue!

🔔 @mooxl @peter-gy @Popalay @MonsterDeveloper @YamenSharaf @EvanZhouDev @erics118 you might want to have a look.

💡 Author and Contributors commands The author and contributors of `mooxl/deepcast` can trigger bot actions by commenting: - `@raycastbot close this issue` Closes the issue. - `@raycastbot rename this issue to "Awesome new title"` Renames the issue. - `@raycastbot reopen this issue` Reopen the issue.
erics118 commented 11 months ago

For Translate command, this currently currently isn't supported because it would fallback to the clipboard if the selected text is empty, leading to the form to always be filled with some data.

It should be working correctly for the Translate Into ... commands

mattouzalem commented 11 months ago

Understood, thanks for this info!

erics118 commented 11 months ago

How about just implementing the selected text part, without defaulting to clipboard? I think that's a solution that makes sense. You can always easily cmd-v to paste your clipboard into the form.

mattouzalem commented 11 months ago

I agree with this solution, it would make it faster to get any text selected from the screen on the extension.

erics118 commented 11 months ago

@raycastbot reopen this issue

erics118 commented 11 months ago

I've implemented it in #9083

mattouzalem commented 11 months ago

Cool, thanks!!