raycast / extensions

Everything you need to extend Raycast.
https://developers.raycast.com
MIT License
5.29k stars 2.98k forks source link

[YouTube Downloader] Loading spinner is not ending after downloaded file #9530

Closed teziovsky closed 7 months ago

teziovsky commented 10 months ago

Extension

https://www.raycast.com/vimtor/youtube-downloader

Description

If I want to download any video as mp3 everything is going all right, but the loading is not ending when the file is downloaded.

https://github.com/raycast/extensions/assets/36273653/c296040c-45c8-470c-b9c9-4b1a23235b63

Steps To Reproduce

  1. Copy the link to the YouTube video
  2. Paste and choose mp3
  3. Click download
  4. Wait for the downloaded file
  5. Check loading spinner

Current Behaviour

The loading spinner is spinning infinitely

Expected Behaviour

Properly show that the file is downloaded correctly

raycastbot commented 10 months ago

Thank you for opening this issue!

🔔 @vimtor @pernielsentikaer @darmiel you might want to have a look.

💡 Author and Contributors commands The author and contributors of `vimtor/youtube-downloader` can trigger bot actions by commenting: - `@raycastbot close this issue` Closes the issue. - `@raycastbot rename this issue to "Awesome new title"` Renames the issue. - `@raycastbot reopen this issue` Reopen the issue.
teziovsky commented 10 months ago

It could be great to have options for more kbps if is it possible 🤔

teziovsky commented 10 months ago

It could be great to have an extension near audio formats like this: 128kbps ({size_of_file} MB) [mp3] It will allow users to search by writing just typing mp3

vimtor commented 10 months ago

Hey @teziovsky!

  1. Does the infinite spinner always happen? We are using the unofficial YouTube API and it's a bit flakky.
  2. Sadly, more kbps are only available on YT premium #8123
  3. Adding [mp3] to the audio formats is a great idea!
teziovsky commented 10 months ago

@vimtor

  1. Yes, every download
  2. Well ok 🥲
  3. Great 🫶
vimtor commented 9 months ago

Regarding the infinite spinner, it probably has to do with your ffmpeg installation. I would suggest trying to reinstall it to see if the problem persists. As for the [mp3], I will add it in one day along with the next batch of updates.

raycastbot commented 8 months ago

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊

raycastbot commented 7 months ago

This issue has been automatically closed due to inactivity.

Feel free to comment in the thread when you're ready to continue working on it 🙂

You can also catch us in Slack if you want to discuss this.

teziovsky commented 7 months ago

😔