Fix: ionic3.0+ '_cols' of undefined error

raychenfj / ion-multi-picker

Multi Item Picker - An Ionic Custom Multi Picker Component

https://raychenfj.github.io/ion-multi-picker/

Other

236 stars 103 forks source link

Closed hsuanxyz closed 7 years ago

hsuanxyz commented 7 years ago

fix: ERROR TypeError: Cannot read property '_cols' of undefined (#42)

raychenfj commented 7 years ago

Thanks for the PR :), but sorry, can't accept it

Simply add this chain validation won't make it right even it somehow pass my ut. But I'm sure it won't pass the e2e test.

Because the root cause of this error is the breaking change of ionic2 picker component.

It doesn't have this.instance anymore, instead, it has this._cmp.instanc now.

raychenfj commented 7 years ago

Correct myself a little bit. this.instance does exist, but only after present. And present return a promise now.