ionic 3.4.0 version must implements IonicFormInput

liugogal commented 7 years ago

like title

raychenfj commented 7 years ago

@liugogal

So Is there any error occurs ? Because after updating my demo, everything works fine.

Also can you point out relative doc ?

giscafer commented 7 years ago

ionic-angular@3.5.0


            Argument of type 'this' is not assignable to parameter of type 'IonicFormInput'. Type 'MultiPicker' is not
            assignable to type 'IonicFormInput'. Property 'initFocus' is missing in type 'MultiPicker'.

      L93:  this.id = 'dt-' + _item.registerInput('multi-picker');
      L94:  this._labelId = 'lbl-' + _item.id;
      L95:  this._item.setElementClass('item-multi-picker', true);

.../multi-picker/multi-picker.ts, line: 462
            Argument of type 'this' is not assignable to parameter of type 'IonicFormInput'.

     L463:    * @private Convert the picker ionChange event object data to string

zwq8299174 commented 6 years ago

一样的错误@giscafer 你解决了么

giscafer commented 6 years ago

@zwq8299174 记得当时是下载源码修改的。没使用npm install方式

raychenfj commented 6 years ago

@giscafer @zwq8299174 hi guys, I would be appreciated if you can send a PR to fix this issue.

raychenfj / ion-multi-picker

ionic 3.4.0 version must implements IonicFormInput #55