Last boolean attr add - Githubissues

rayd / html-parse-stringify2

Parses well-formed HTML (meaning all tags closed) into an AST and back. quickly.

21 stars 11 forks source link

Last boolean attr add #17

Open MurakamiKennzo opened 6 years ago

MurakamiKennzo commented 6 years ago

close #15

MurakamiKennzo commented 6 years ago

HI, @rayd I am happy you can reply me , but since I am greener here and can you tell me how to find failed check? and what should I do ? thanks.

rayd commented 6 years ago

Hi @MurakamiKennzo, thanks for the fix! Would you mind adding a test to verify the fix?

I think the Travis CI failure is because I've configured it incorrectly. I will try to get this fixed.

MurakamiKennzo commented 6 years ago

yes, i try to add test similar as your test code in parse-tag.js. but I cannot run npm test. since I am unfamiliar with zuul,. so I cannot fix it and push code.

DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.

it seems node deprecated api bug and configured incorrectly caused. waiting....