raydac / java-comment-preprocessor

preprocessor for computer languages with C-like comment format (C/C++/Java/Go)
Apache License 2.0
172 stars 27 forks source link

Can I build/run jcp without meta-* dependencies? #19

Closed praiskup closed 6 years ago

praiskup commented 6 years ago

In fedora, we don't have the meta-* jars: https://bugzilla.redhat.com/show_bug.cgi?id=1584114

Is there a possibility to make that meta-* stuff optional for jcp?

raydac commented 6 years ago

how do you build the preprocessor? meta packages are published in maven central, fedora has some specific repository?

praiskup commented 6 years ago

Yes, we have our own set of (RPM) packages.

raydac commented 6 years ago

and what if needed jars will be included locally into project?

praiskup commented 6 years ago

That would be much more convenient, yes.

raydac commented 6 years ago

and such artifact presented in fedora repository?

<groupId>com.google.code.findbugs</groupId>
<artifactId>jsr305</artifactId>

is it possible for me to emulate build process to check it ?

praiskup commented 6 years ago

and such artifact presented in fedora repository?

Not yet :-/

is it possible for me to emulate build process to check it ?

Probably, but it requires some level of experience to have it done quickly; you can try to docker run -ti fedora:rawhide, and run RPM build inside (you need the spec file + sources, available in https://src.fedoraproject.org/rpms/java-comment-preprocessor). But I'd be glad to give try the build instead of you.

raydac commented 6 years ago

you can try current snapshot version, I have removed meta dependencies and it can be build with mvn clean install -P'!metacheck'

praiskup commented 6 years ago

Awesome, it works fine now. Thanks for the fix, @raydac.

praiskup commented 6 years ago

Test-build is here: https://copr.fedorainfracloud.org/coprs/praiskup/new-java-comment-preprocessor/monitor/

It would be awesome to have a new release with this :-)

raydac commented 6 years ago

version 6.1.4 has been published in the maven central

praiskup commented 6 years ago

Thanks! I updated fedora package to 6.1.4: https://koji.fedoraproject.org/koji/taskinfo?taskID=27672154

I temporarily downstream reverted 6ca437135e19c7506286458416485b0d6abcbf1c till we have the deps in Fedora (I guess that's a matter of time).