search

raydenlim / pe

0 stars 0 forks source link

Identical Person in Group #3

Open raydenlim opened 10 months ago

raydenlim commented 10 months ago

image.png

From my understanding, you guys check index using email. However, I was still able to add the same email into a group:

image.png

You can try replicating this bug by:

  1. editing the original AlexYeoh's email to something else
  2. Create a new person with alexyeoh's old email
  3. Join said person to the same tut group.
nus-pe-script commented 10 months ago

Team's Response

It is a functionality bug as this bug should not be allowed, but it worked in his/her case. We labelled it a low severity as we believe that it is not common for users to do the action(what the tester tested) or change their email(we intended email changes in the case of typos, not for deliberate changes).

Items for the Tester to Verify

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I apologize for the slight error in the "replication". (Time tight) 1. editing the original AlexYeoh's email to something else \ ~~2. Create a new person with alexyeoh's old email~~\ ~~3. Join said person to the same tut group.~~ All it took was editing the email to something else. The Old email object reference is not updated accordingly. Causing identical persons to be created. This would bring great inconvenience to the users, as there will be a case where there are 2 instances of the same person (with different emails) in the group. The group will count the old instance as 1 person as well. May I refer you to the CS2103T website on severity level as well: ![image.png](https://raw.githubusercontent.com/raydenlim/pe/main/files/1284eaf3-9533-4b27-b92b-231e8ed80bf9.png) Based on your product's aims and motivations, to provide " a hassle-free team formation solution forCS2103T and CS2101students to browse profiles and connect for the team project", this error will probably affect most users, as typos are very common. Even for you guys, you had typo in your UG as well. So its safe to assume that email typo is not uncommon. For added logos: ![image.png](https://raw.githubusercontent.com/raydenlim/pe/main/files/24762ae5-d26b-42f6-8b60-97f033ce7b54.png) Here is some statistics on typo errors. I could be harsh and label this as `high` during PE, but i put it as a medium severity instead. However, this bug is certainly NOT low. since it affects the normal operations of the product, and creates major inconveniences.