raydenlim / pe

0 stars 0 forks source link

Misleading Valid Name #8

Open raydenlim opened 9 months ago

raydenlim commented 9 months ago

image.png

Character restriction mentions that Only alphabetical characters (A-Z, a-z) and spaces are allowed. And the valid names displayed includes names with symbols, such as La Niña and Élise DuPont.

This may be confusing to users, as they think that they can add Niña, but they cant add Niña :(

nus-se-bot commented 9 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Wrong valid inputs for name in UG

Description

Trying to add a new person

Steps to reproduce

  1. Launch the application for the first time to load initial data.
  2. Run add n/La Niña 2 m/Computer Science y/2 e/johnd@u.nus.edu d/I’m a Frontend Developer t/06 t/19 sm/https://www.linkedin.com/in/john-doe-123456789 sm/https://www.linkedin.com/in/john-doe-123456789 nt/local g/m.

Expected behaviour

The person should be added successfully as this is sample valid input from the User Guide (same issue for name Élise DuPont)

Actual behaviour

An error is raised Names should only contain alphabetical characters and spaces, and it should not be blank. It should also not exceed 30 characters.

Reason for severity

Likely documentation issue (wrong valid inputs) since it is stated "Character Restrictions: Only alphabetical characters (A-Z, a-z) and spaces are allowed"


[original: nus-cs2103-AY2324S1/pe-interim#3962] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We set the severity as very low as we believe it does not affect the usage of the app. For people who have symbols in their name, they can type their name without it, so the app would still work for them.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** As stated on the CS2103T website, a verylow severity is meant only for cosmetic errors: ![image.png](https://raw.githubusercontent.com/raydenlim/pe/main/files/a7be18a3-a684-4dd4-a295-dcd31ab21108.png) This error is NOT cosmetic, as its not a typo. (No one can accidentally type a name with accents without intentionally changing their keyboard settings). Moreover, these accented names appear twice, not just a 1 off issue. Hence, this bug is MINIMALLY a `low` severity.