search

rayfarias56 / shpe

shpe uiuc's website
http://www.shpe-uiuc.org
2 stars 0 forks source link

Embedded Calendar #124

Closed rayfarias56 closed 8 years ago

rayfarias56 commented 8 years ago

The eboard would like the events page to be an embedded google calendar.

rayfarias56 commented 8 years ago

Swapped to victoria because this will now be the entire events page #117

haugerbr commented 8 years ago

Just an fyi, changing that page might have broken attendance with the card reader. Also why did the eboard want an embedded Google calendar? Using that will pretty much create a bad experience on mobile for viewing events. I'm also probably a little upset since I wrote this page and there were various reasons we didn't use an embedded Google calendar.

rayfarias56 commented 8 years ago

Why would it break attendance? It was a change to a static_page and not any of the events CRUD page.

Also, they think the calendar will be easier to look at and they don't care about mobile too much.

haugerbr commented 8 years ago

Because I'm pretty sure the view referenced that file unless we duplicated the code. Even if the CRUD model is still intact, if the view got broken it's pretty much useless. Even though I know you're doing this because the eboard wanted it, please tell me you understand how bad it is to change it to an iframe.

rayfarias56 commented 8 years ago

Lol, yes, I know how bad this is... um, at least design wise, I don't know if you hinted at security issues. I can't think of any security problems, as it's coming from Google. What do you suggest to do here? I could easily fix any attendance tracking issues.

haugerbr commented 8 years ago

I would suggest that we find out what they wanted from the iframe and implement that as a pure html\css solution so that it can still be responsive and won't look out of place like an iframe.

On Sat, Nov 21, 2015 at 12:50 PM, Raymond Farias notifications@github.com wrote:

Lol, yes, I know how bad this is... um, at least design wise, I don't know if you hinted at security issues. I can't think of any security problems, as it's coming from Google. What do you suggest to do here? I could easily fix any attendance tracking issues.

— Reply to this email directly or view it on GitHub https://github.com/rayfarias56/shpe/issues/124#issuecomment-158680027.

Sincerely, Brian Hauger

rayfarias56 commented 8 years ago

We'd have to make that look and feel like a calendar in order to make the eboard happy. Let's use an iframe for the time being, but make an html/css solution high priority for the next milestone. I'll also file an issue to test the attendance card reader in this milestone.

haugerbr commented 8 years ago

Sounds good.

On Tue, Nov 24, 2015 at 10:03 AM, Raymond Farias notifications@github.com wrote:

We'd have to make that look and feel like a calendar in order to make the eboard happy. Let's use an iframe for the time being, but make an html/css solution high priority for the next milestone. I'll also file an issue to test the attendance card reader in this milestone.

— Reply to this email directly or view it on GitHub https://github.com/rayfarias56/shpe/issues/124#issuecomment-159357746.

Sincerely, Brian Hauger

rayfarias56 commented 8 years ago

Actually, @haugerbr, how does this look?

https://profromgo.com/blog/google-calendar-responsive/

Could be a solution.