search

rayh / xcoder

ruby wrapper for Xcode build tools to aid automating builds
MIT License
412 stars 70 forks source link

Fix BuildPhase.add_build_file() when FileReference exists #47

Closed torarnv closed 12 years ago

torarnv commented 12 years ago

We should look up existing BuildFiles, not FileReference, when determining whether or not to add a new BuildFile.

torarnv commented 12 years ago

Never mind, I misinterpreted the bug I was seeing :)

torarnv commented 12 years ago

Shouldn't find_file_by = file.name || file.path be find_file_by = file.path || file.name though, so that two file references with the same names but different paths can still be added as two separate build-files?

rayh commented 12 years ago

Sounds reasonable... will the project build ok with two similarly named files?

torarnv commented 12 years ago

Yepp, that's supported by Xcode. I'll put up a patch, thanks!