search

rayh / xcoder

ruby wrapper for Xcode build tools to aid automating builds
MIT License
412 stars 70 forks source link

Do not try to install an already installed provisioning profile #64

Closed dunkelstern closed 11 years ago

dunkelstern commented 11 years ago

This results in a race condition because the already installed profile is deleted before reinstalling it, so it deletes the file it wants to install

rayh commented 11 years ago

The reason for deleting/installing is because we use the UUID to determine whether the profile is installed, but if it has been modified, it still needs to be erased. I wonder if it can just be copied over the top without the deletion.

dunkelstern commented 11 years ago

I ran into that problem if i supplied the already installed profile to the builder. The change only checks if both paths are the same and then skips, it compares the complete path, not just the name so i think it is safe

rayh commented 11 years ago

I'm not sure how that will deal with the situation when the profile is already installed and there is a new version you have provided with the same UUID. As far as I can tell, the path check wouldn't install the new version.

On 13 April 2013 01:55, Johannes Schriewer notifications@github.com wrote:

I ran into that problem if i supplied the already installed profile to the builder. The change only checks if both paths are the same and then skips, it compares the complete path, not just the name so i think it is safe

— Reply to this email directly or view it on GitHubhttps://github.com/rayh/xcoder/pull/64#issuecomment-16300958 .

Ray Hilton

(maker of mobile apps)

13/243 Collins St, Melbourne VIC 3000 | +61 (0) 430 484 708 | http://ray.sh

IvanUshakov commented 11 years ago

watch to #63, please

dunkelstern commented 11 years ago

ok, just pull the change from @IvanUshakov that includes this issue and is even cleaner. I'm closing this one.