rayh / xcoder

ruby wrapper for Xcode build tools to aid automating builds
MIT License
412 stars 70 forks source link

dSYM filename #68

Open valeriomazzeo opened 11 years ago

valeriomazzeo commented 11 years ago

When using builder.package the generated file is in this format:

MyProject-Debug-1.0.dSYM.zip

but, standing to the jenkins testflight plugin documentation:

The path of the dSYM ZIP file(s) to upload to testflight. If not specified, for each IPA file found, a related '-dSYM.zip' file is searched for. If found it is added to the upload request as dsym parameter. Note: in the future this parameter will probably be removed and replaced with an optional argument to upload dSYM files or not.

Now it would be great if the generated file will follow that format, or if at least we can choose, or pass the delimiter as parameter in the script.

I know the filename can be specified in the plugin manually, or it can be renamed after, but this will help to have a very smoother integration.

rayh commented 11 years ago

xcoder already provides testflight integration, and so the intention was to avoid having to do too much "inside" of jenkins - easier to use with other CI environments, and also to run locally.

We could change the file name convention, I just wonder what issues that would create. There is no reason why you couldn't simple rename the file after it is generated by xcoder - just another bash build step.

Specifying ia delimiter is very specific, so I would avoid that route... perhaps we can come up with a block that is assigned to the builder and is yielded to for naming of output assets.

On 3 June 2013 21:41, Valerio Mazzeo notifications@github.com wrote:

When using builder.package the generated file is in this format:

MyProject-Debug-1.0.dSYM.zip

but, standing to the jenkins testflight plugin documentation:

The path of the dSYM ZIP file(s) to upload to testflight. If not specified, for each IPA file found, a related '-dSYM.zip' file is searched for. If found it is added to the upload request as dsym parameter. Note: in the future this parameter will probably be removed and replaced with an optional argument to upload dSYM files or not.

Now it would be great if the generated file will follow that format, or if at least we can choose, or pass the delimiter as parameter in the script.

I know the filename can be specified in the plugin manually, or it can be renamed after, but this will help to have a very smoother integration.

— Reply to this email directly or view it on GitHubhttps://github.com/rayh/xcoder/issues/68 .

Ray Hilton

(maker of mobile apps)

13/243 Collins St, Melbourne VIC 3000 | +61 (0) 430 484 708 | http://ray.sh

valeriomazzeo commented 11 years ago

I opened an issue on the jenkins bugtracker asking the same things about the testflight plugin.

So, hopefully it will scan the folder searching by other kind of filename (like .dSYM.zip) to increase the compatibility.

Probably it makes more sense to be fixed in the testflight plugin then?

rayh commented 11 years ago

Perhaps they can accept a file pattern?

I'll take a look, unless you want to submit a PR of your proposed changes?

On 3 June 2013 23:40, Valerio Mazzeo notifications@github.com wrote:

I opened an issue on the jenkins bugtracker asking the same things about the testflight plugin.

So, hopefully it will scan the folder searching by other kind of filename (like .dSYM.zip) to increase the compatibility.

Probably it makes more sense to be fixed in the testflight plugin then?

— Reply to this email directly or view it on GitHubhttps://github.com/rayh/xcoder/issues/68#issuecomment-18841622 .

Ray Hilton

(maker of mobile apps)

13/243 Collins St, Melbourne VIC 3000 | +61 (0) 430 484 708 | http://ray.sh

valeriomazzeo commented 11 years ago

this is the link of the issue: https://issues.jenkins-ci.org/browse/JENKINS-18175

let see what they say, before proceed.

lacostej commented 10 years ago

Fixed in 65e7d59 on testflight plugin side. I will look closer into xcoder as I prefer Jenkins to do as little as possible. Thanks for the pointer!