Change vendor dependency to use DOMPDF

[raykolbe]

Currently we include a full copy of DOMPDF with the DOMPDFModule release. This was done originally because the DOMPDF project was on Google Code and not GitHub. Since then they have moved to GitHub with tagged releases.

I believe the current compatible release is https://github.com/dompdf/dompdf/tree/v0.5.2

[raykolbe]

We now depend on DOMPDF Packagist releases. Even though there isn't a tagged release of DOMPDF, we lock in to a specific commit, so there is no need to worry about the master branch changing over time.

This releases has been tagged at v0.3.1 https://github.com/raykolbe/DOMPDFModule/tree/v0.3.1

[bakura10]

I have a problem with this. Now, it depends on DomPDF on GitHub, which itself depends on a strange library called: "phenx/php-font-lib"

However, whenever I deploy, I have errors because of this. Locally, it the "phenx" folder is also empty.

[raykolbe]

Hrmm. Even after deleting your whole vendor directory and doing a fresh update?

I also use minimum-stability: dev, which dompdf requires it seems. Not sure if you have that in your composer file or if that would affect things.

[bakura10]

I also have those settings. In local no error are thrown, except that the "phenx" folder is completely empty (which is strange btw). I tried to explicitly set the dependency in my composer.json, but still, "phenx" is empty. When deploying in Amazon Elastic Beanstalk, an error is thrown because of this package, and my application cannot be deployed.

I had to go back to v 0.2.0.

[raykolbe]

I just did a Composer self-update, deleted my vendor dir, then a clean Composer update and have all of the files in vendor/phenx/php-font-lib directory.

What does your composer.json file look like?

[bakura10]

This is strange indeed :/.

{
    "minimum-stability": "dev",
    "require": {
        "php": ">=5.3.3",
        "zendframework/zendframework": "2.2.1",
        "symfony/serializer": "2.3.2",
        "zf-commons/zfc-rbac": "0.2.0",
        "aws/aws-sdk-php-zf2": "1.0.3",
        "slm/mail": "1.0.1",
        "doctrine/dbal": "2.4.0-RC2",
        "doctrine/orm": "2.4.0-RC2",
        "doctrine/doctrine-module": "0.8.0-beta1",
        "doctrine/doctrine-orm-module": "0.8.0-beta1",
        "dino/dompdf-module": "0.3.1",
        "paypal/adaptivepayments-sdk-php": "3.4.102",
        "zfr/zfr-mailchimp": "1.0.0-beta2",
        "zfr/zfr-mailchimp-module": "1.0.0-beta2"
    }
}

[raykolbe]

What's the output after a Composer update? Also, what version of Composer are you using?

On Thu, Sep 5, 2013 at 9:35 AM, Michaël Gallego notifications@github.comwrote:

This is strange indeed :/.

{ "minimum-stability": "dev", "require": { "php": ">=5.3.3", "zendframework/zendframework": "2.2.1", "symfony/serializer": "2.3.2", "zf-commons/zfc-rbac": "0.2.0", "aws/aws-sdk-php-zf2": "1.0.3", "slm/mail": "1.0.1", "doctrine/dbal": "2.4.0-RC2", "doctrine/orm": "2.4.0-RC2", "doctrine/doctrine-module": "0.8.0-beta1", "doctrine/doctrine-orm-module": "0.8.0-beta1", "dino/dompdf-module": "0.3.1", "paypal/adaptivepayments-sdk-php": "3.4.102", "zfr/zfr-mailchimp": "1.0.0-beta2", "zfr/zfr-mailchimp-module": "1.0.0-beta2" }}

— Reply to this email directly or view it on GitHubhttps://github.com/raykolbe/DOMPDFModule/issues/12#issuecomment-23867781 .

[bakura10]

In local I have no error. When I deploy to Elastic Beanstalk, it says that it cannot retrieve phenx because of an uncommitted "README" file in phenx (yeah I know this is strange….).

[raykolbe]

Is there a higher level git repo that is conflicting with your vendor directory?

[bakura10]

Mmhh I'm not on my main computer so I cannot tell you but no, nothing fancy. It's the first time that running Composer leads to an empty folder for one dependency :/.