search

rayman1104 / ra-data-nestjsx-crud

Data provider which integrates React Admin with NestJS CRUD library
MIT License
100 stars 27 forks source link

small fix - fixed type checking for filter operation #22

Closed AlexanderBich closed 2 years ago

AlexanderBich commented 2 years ago

Thanks for the lib, I will post fixes here, so please make sure to check your notifications)

rayman1104 commented 2 years ago

Cool, thanks. Is it ready to merge or you plan to add more changes later?

AlexanderBich commented 2 years ago

@rayman1104 yes, it's ready, but if I will find anything else I will create a separate PR for it.

AlexanderBich commented 2 years ago

@rayman1104 can you please merge it?)

Brunni commented 2 years ago

Thank you for the fix. I really need it for boolean filters! Can it be published?

rayman1104 commented 2 years ago

@Brunni must be published, isn't it? Version 1.1.7.

Brunni commented 2 years ago

@rayman1104 In 1.1.7 version it is still the old check in the index.js file:

if (typeof flatFilter[key] === 'number' || flatFilter[key].match(/^\d+$/)) {
                ops = crud_request_1.CondOperator.EQUALS;
}
rayman1104 commented 2 years ago

@Brunni thanks for the heads up. Just published 1.1.8, should be good now.