search

raymanfx / ffimage

Foreign function image handling in Rust
MIT License
11 stars 3 forks source link

Implement conversion from Yuv422 to RGB and BGR #1

Closed JannikP closed 1 year ago

JannikP commented 1 year ago

Implemented the trait ConvertSlice for Yuv422 to allow conversions from Yuv422 packed images to RGB and BGR images. The colorspace conversions are delegated to the existing code in the Yuv implementation. I tested the conversion from YUYV to RGB with data from a Basler camera.

raymanfx commented 1 year ago

Hi, could you please rebase this against the latest master branch? I just merged the next branch into it which should have happened a long time ago.

JannikP commented 1 year ago

Hi, could you please rebase this against the latest master branch? I just merged the next branch into it which should have happened a long time ago.

Done.

raymanfx commented 1 year ago

Hmm, it shows 13 commits and 19 changed files now. Did you merge the master branch into your local one? This makes it hard to review the change, thus I'd propose a git rebase .. against the master branch of this repo.

Alternatively, you can checkout the master branch and git cherry-pick <your_commit> on top, that should yield the same (clean) result.

JannikP commented 1 year ago

Alternatively, you can checkout the master branch and git cherry-pick <your_commit> on top, that should yield the same (clean) result.

I'm going to do this today, maybe tomorrow.

JannikP commented 1 year ago

Finally I had time to clean it up. Now there is only one changed file with just my additions.