search

raymond-jgler / java-class-jacksonizer

A tool to bulk annotate existing constructor with given annotations, or to add a default constructor to Java classes if without.
MIT License
3 stars 0 forks source link

New Inserted Constructor Code Should Be Accessed As "Protected" If Its Class Has Any Child #5

Closed raymond-jgler closed 11 months ago

raymond-jgler commented 11 months ago

Issue

image

Expected output :

The access modifier keyword for the constructor in the above img should have been protected for its children to reference.

raymond-jgler commented 11 months ago

Refer to https://github.com/trgpnt/Java-Class-Annotatable-Constructor-Templater/blob/b89e8eff02dc058ab98b65323e8f339294685ae0/src/main/java/com/aggregated/BuildAnnotatableCodePhase.java#L848 and https://github.com/trgpnt/Java-Class-Annotatable-Constructor-Templater/blob/b89e8eff02dc058ab98b65323e8f339294685ae0/src/main/java/com/aggregated/BuildAnnotatableCodePhase.java#L851

Maybe a bug..

hienkwan commented 11 months ago

This ticket should be able to close now, as it's already been fixed. image

raymond-jgler commented 11 months ago

Thanks @hienkwan for the after image !

Closed as far as test-result is concerned