idbrii
commented
2 years ago Looking at results.diff, seems like there are cases where the OUT text is preferable to the ok text. OUT has indents for continued lists and compound booleans and more reasonable indents for function arguments:
nmap/afp.OUT.lua
nmap/afp.ok.lua
--- nmap/afp.ok.lua 2022-03-12 15:31:45.257628900 -0800
+++ nmap/afp.OUT.lua 2022-03-12 15:32:50.520359400 -0800
@@ -621,7 +621,7 @@ Proto = {
-- parse and store the offsets in the 'header'
pos, offsets.machine_type, offsets.afp_version_count,
- offsets.uam_count, offsets.volume_icon_and_mask
+ offsets.uam_count, offsets.volume_icon_and_mask
= bin.unpack(">SSSS", packet.data, pos)
-- the flags are directly in the 'header'
@@ -765,7 +765,7 @@ Proto = {
pos, port = bin.unpack(">S", packet.data, pos)
table.insert(result.network_addresses,
- string.format("[%s]:%d", table.concat(octet, ':'), port))
+ string.format("[%s]:%d", table.concat(octet, ':'), port))
end
end
@@ -1728,7 +1728,7 @@ Helper = {
local item = ( response.result.file ) and response.result.file or response.result.dir
local item_type = ( response.result.file ) and "-" or "d"
local privs = ( item.UnixPrivileges and item.UnixPrivileges.ua_permissions ) and
- item.UnixPrivileges.ua_permissions
+ item.UnixPrivileges.ua_permissions
if ( privs ) then
local uid = item.UnixPrivileges.uid
local gid = item.UnixPrivileges.gid
@@ -1758,8 +1758,8 @@ Helper = {
end
return true, ( response.result.file and
- response.result.file.ExtendedDataForkSize) and
- response.result.file.ExtendedDataForkSize or 0
+ response.result.file.ExtendedDataForkSize) and
+ response.result.file.ExtendedDataForkSize or 0
end,
I understand nothing has changed about this plugin in 7 years, but I don't know the history of the test cases.
Only 27/108 tests in the nmap folder pass. Is that folder of tests aspirational or did they once work and updates to vim broke them?
Using Ubuntu 20.04.1 LTS under Windows Subsystem for Linux.