raymondlouie / MiniMarS

4 stars 2 forks source link

Error in geneBasisR::gene_search, Selected library size should be smaller than number of genes in the counts matrix. #45

Closed anglixue closed 11 months ago

anglixue commented 11 months ago

I've mentioned in error in the last meeting. The geneBasisR function returned errors when num_markers = 50 in many cases. It turns out the package will subset the informative genes by sce = geneBasisR::retain_informative_genes(sce), and in those cases, the subset contains no less than 50 genes.

The conditional statement didn't address the boundary problem

if (geneBasis_num_markers<num_markers){
        warning("\n Number of markers from geneBasis is less than the number of input markers. Reducing number of markers. \n")
        num_markers = geneBasis_num_markers-1
    }

The "equal symbol" should be "no less than". I will test it again to see if solve the bug.

anglixue commented 11 months ago

Solved. Updated in the v0.2.0.