search

raynerljm / pe

0 stars 0 forks source link

Error message when an invalid time is provided is misleading #4

Open raynerljm opened 2 years ago

raynerljm commented 2 years ago

Bug: Error message when an invalid time is provided is misleading

image.png

Description: When inputting an invalid time (2400) BUT the time format is correct (HHmm), the error message displayed is 'DateTime should be formatted as dd-MM-yyyy HHmm; e.g. 30-04-2022 1400'. I do acknowledge that in the UG under Interpreting Errors section:

image.png

this is mentioned. However, it would be clearer for the users if the error message itself clarified the error instead of users having to refer to the UG to understand.

Steps to reproduce: Enter the command add n/123 u/123.com d/24-02-2023 2400 dur/24 m/6 r/N

Expected outcome: The error message should be about the validity of the time, not about the date time format.

Actual outcome: The error message given informs me that I have provided an incorrect date format.

nus-pe-script commented 2 years ago

Team's Response

Thank you for raising this issue.

However, we are choosing to reject this issue as we believe that most users should be able to check and understand that the input is an invalid time.

Furthermore, if the user is still unsure about the error message displayed, the error summary table in the UG can help to point them in the right direction.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]