search

raynor85 / react-native-material-selectize

A React Native component inspired to Selectize which follows Material Design guidelines.
MIT License
55 stars 32 forks source link

More chip style overrides #10

Closed c-moss-talk closed 6 years ago

c-moss-talk commented 6 years ago

Correct me if I'm wrong, but currently it seems the text color and the icon color of the chip are both not overridable using chipIconStyle and chipStyle. Since the chip component has 5 different subcomponents could it be better to just pass a chipStyle object with each subcomponent as a key? Like so:

chipStyle = {
  root: {},
  container: {},
  text: {},
  iconWrapper: {},
  icon: {},
}

Or do you feel like at this point you'd just be supplying your own component instead? If not, I can submit a PR.

raynor85 commented 6 years ago

That's a good concern, but due to the simplistic nature of the Chip component, I feel like passing a custom component would be better.

raynor85 commented 6 years ago

Although, since you're offering, I would be happy to merge your PR if you are willing to do it.

c-moss-talk commented 6 years ago

no time