rayo / xmpp

Fork of the XMPP XEP repo
http://gitorious.org/xmpp
3 stars 3 forks source link

Optionally include platform-specific end reason codes #71

Closed benlangfeld closed 11 years ago

benlangfeld commented 11 years ago

Some applications require more detailed end reasons such as circuit congestion, etc. Asterisk and FreeSWITCH provide their own enumerations, while other platforms (eg PRISM) might expose SIP codes or something else entirely. This patch allows for passing those specific codes up to the Rayo client after categorisation as one of the more general Rayo end reasons.

@crienzo, @bklang and @loopingrage: I'd like your input on this, please.

benlangfeld commented 11 years ago

@JustinAiken also has an interest in this

crienzo commented 11 years ago

I don't have a problem with this.

crienzo commented 11 years ago

If I were to implement this, I'd pass along FreeSWITCH's internal enumeration instead of the endpoint-specific code.

benlangfeld commented 11 years ago

@bklang expressed concern that code gives the impression of normalisation, and so I will replace this with platform_code to avoid ambiguity.