search

rayolanderos / UT-APT-MiniProject

0 stars 0 forks source link

Subscriptions #10

Closed gleono closed 7 years ago

gleono commented 7 years ago

It took me a little more than expected, dealing with a repeated property of Keys was a little tricky. One significant change that I think I saw before submitting this was that the owner property in Stream is the user_id() and not his/her email. (Recommended practice)

There's a bug, where after subscribing/unsubscribing from streams, it takes a while to reflect that change. It might maybe that the browser is caching the page, but after refreshing you can see actual status of user's subscription.

At this point I think we can refactor a bunch of duplicated code and but it in a base class. Also is worth considering pushing more querying and updating methods into the models.

rayolanderos commented 7 years ago

I believe the "bug" you are describing is a problem of the local datastore. It takes a while to update itself. It happens to me when creating/deleting streams as well. You have to re-refresh to see the resource appear/gone. I've been ignoring it because it also happened in some other test projects that I downloaded to get a better understanding of some features. I suspect this won't be an issue when it's deployed but we should keep an eye out for it.

gleono commented 7 years ago

Oh yeah, I wasn't sure which to use and it was already late. I'll fix it when I get home.

gleono commented 7 years ago

Done, I changed to use stream.views. Also noticed that I introduced a bug by not putting the try_create_connexus_user() in the right place. Is fixed now too.