search

raysan5 / raygui

A simple and easy-to-use immediate-mode gui library
zlib License
3.36k stars 289 forks source link

Controls don't consider `mouse down` and `mouse up` positions #339

Open danielchasehooper opened 11 months ago

danielchasehooper commented 11 months ago

It's possible to toggle a checkbox by pressing down the mouse outside the checkbox, dragging the mouse over the checkbox, and releasing the mouse. It's generally preferable for checkboxes to require both the mouse down event and the mouse up event to both occur within the checkbox's bounds. This is also an issue for other raygui controls, like buttons and sliders.

https://github.com/raysan5/raygui/assets/1472250/5096c782-efa9-40cd-bf81-f66ba53271a7

This issue is particularly annoying in interfaces where dragging is part of the user interactions - the user could be dragging something and then unintentionally trigger controls when the mouse is released. Take this 3d program for example:

https://github.com/raysan5/raygui/assets/1472250/65c3cf77-30bb-4e57-8c93-d68ae18ce4dd

(yes in this example you can manually;y work around around the issue, but that's work the end user is doing to get a control to work the way it should've worked in the first place)

raysan5 commented 11 months ago

This could be a bit tricky, actually it is difficult to implement it in an immediate mode UI, it would require some kind of static variable registering where the press was initiated... In my tools I take care of that at user side, where I can create that kind of static variables.

danielchasehooper commented 11 months ago

You could totally add a static Vector2 mouseDownPosition; - raygui already uses static variables for text buffers.

mashhoodalvi commented 7 months ago

Saw that the other day here. tsoding uses raylib in his project. He is explaining cancellability of UI interactions and the problem he encountered when he releases the mouse over an other UI element. He fixed it by introducing active UI element IDs. Could such a concepts also be used in Raygui? I guess ImGui also use such a concept.

raysan5 commented 7 months ago

@mashhoodalvi Maybe but it should be investigated... as commented I try to avoid/minimize global states as much as possible...

raysan5 commented 6 months ago

Two new globals have been added to raygui that could be used to address this kind of issues:

static bool guiControlExclusiveMode = false;    // Gui control exclusive mode (no inputs processed except current control)
static Rectangle guiControlExclusiveRec = { 0 }; // Gui control exclusive bounds rectangle, used as an unique identifier