search

raysan5 / raylib-gamejam-template

A template for the raylib gamejams
zlib License
57 stars 16 forks source link

fix PATH format #3

Closed computermouth closed 11 months ago

computermouth commented 12 months ago

I'd been getting an error on building on PLATFORM_WEB

$ make PLATFORM=PLATFORM_WEB -B
make raylib_game
make: make: No such file or directory
make: *** [Makefile:311: all] Error 127

here's the path that was being produced in the Makefile

$ make PLATFORM=PLATFORM_WEB -B other
~/.emsdk;~/.emsdk/upstream/emscripten;~/.emsdk/upstream/bin;~/.emsdk/node/14.15.5_64bit/bin;:$(PATH)

here's the path now (which looks better)

$ make PLATFORM=PLATFORM_WEB -B other
~/.emsdk:~/.emsdk/upstream/emscripten:~/.emsdk/upstream/bin:~/.emsdk/node/14.15.5_64bit/bin:/home/byoung/.emsdk/upstream/emscripten:/home/byoung/.emsdk:/home/byoung/.volta/bin:/home/byoung/.local/bin:/home/byoung/bin:/home/byoung/.cargo/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/usr/local/go/bin

the $$PATH append was breaking my PATH, but I also noticed the separators used here were ;, fixed that as well, now my builds work as expected.

The builds also worked with the ;, but I think that's only because my PATH was also properly set up outside the Makefile.

computermouth commented 12 months ago

My changes might be a bit naive. Discord discussion here: https://discord.com/channels/426912293134270465/661385466766950403/1180186471299305532

Maybe the best route forward is to not try to cover all the cases possible here, and just leave the PATH up to the dev.