search

raysect / source

The main source repository for the Raysect project.
http://www.raysect.org
BSD 3-Clause "New" or "Revised" License
86 stars 23 forks source link

Feature/lenses #355

Closed Mateasek closed 4 years ago

Mateasek commented 4 years ago

Added tests for lenses.Test rays are launched against lenses. Hit point and angle of incidence are compared to the expected values.

Construction of Biconvex, PlanoConvex and Meniscus lenses changed to avoid unspecified behaviour.

Meniscus lens does not pass the tests yet. Problems are raised by the barrel surface close to the edge of the back surface.

Passing of argumens in test methods might be still changed to allow more versatility.

CnlPepper commented 4 years ago

Thanks for the PR. I'm having a look through and I've noticed a some potential issues relating to numerical accuracy of the ray intersections. I'm going to need to spend a little more time to go through these to properly understand the edge cases. I think I'll merge these into a side branch and make one or two edits before merging into development.