raysect / source

The main source repository for the Raysect project.
http://www.raysect.org
BSD 3-Clause "New" or "Revised" License
86 stars 23 forks source link

Vector functions require long imports in Cython #361

Closed jacklovell closed 4 years ago

jacklovell commented 4 years ago

Similar to #360, the vector3d function objects require very long Cython imports because the base classes are missing from the __init.pxd__ files in functionxd.

The python imports have a nice symmetry between float and vector3d: the same should be true of the cython imports.

For example:

from raysect.core.math.function.float cimport Function1D, autowrap_function1d
from raysect.core.math.function.vector3d.function1d.base cimport Function1D
from raysect.core.math.function.vector3d.function1d.autowrap cimport autowrap_function1d

Should be:

from raysect.core.math.function.vector3d cimport Function1D, autowrap_function1d
CnlPepper commented 4 years ago

Thanks for the PR.