Mateasek
commented
4 years ago @CnlPepper the unit tests used to catch all the problems I could come up with. I've checked the code with one objective we have modeled for in Zemax and it seems it is all correct. Thanks for looking into this!
CnlPepper
Updated the spherical lens construction to avoid numerical issue caused by coincident faces. Optimisations have been added for small lenses.
@Mateasek could you please check your use cases and confirm I've not introduced any bugs. Your units tests were very useful, they have hopefully caught everything, but just in case please double check.
If you are happy I'll merge them into development.