Closed anujk14 closed 3 months ago
vercel[bot]
commented
3 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| frontier | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 12, 2024 6:31am |
coveralls
commented
3 months ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| core/webhook/service.go | 0 | 1 | 0.0% | ||
| core/group/service.go | 0 | 5 | 0.0% | ||
| <!-- | Total: | 0 | 6 | 0.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| core/group/service.go | 1 | 0.0% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 9417646654: | -0.001% |
| Covered Lines: | 9642 |
| Relevant Lines: | 103552 |
coveralls
commented
3 months ago This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| core/webhook/service.go | 0 | 1 | 0.0% | ||
| core/group/service.go | 0 | 5 | 0.0% | ||
| <!-- | Total: | 0 | 6 | 0.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| core/group/service.go | 1 | 0.0% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 9417646654: | 0.08% |
| Covered Lines: | 9887 |
| Relevant Lines: | 105319 |
coveralls
commented
3 months ago This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| core/webhook/service.go | 0 | 1 | 0.0% | ||
| core/group/service.go | 0 | 10 | 0.0% | ||
| <!-- | Total: | 0 | 11 | 0.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| core/group/service.go | 1 | 0.0% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 9417646654: | 0.08% |
| Covered Lines: | 9887 |
| Relevant Lines: | 105324 |
We require a webhook which notifies downstream services about removal of user from groups. This PR introduces that into the service.
The reason for doing this in service is so that this event is triggered even if different handlers are used to perform this action.
The idea behind adding this instead of adding more and more information into policy events is to provide an easy to understand event to downstream services so that appropriate action can be taken by them. A few more events such as this will be introduced in subsequent PRs.