fix: billing account with no state in db were failing entitlement checks

raystack / frontier

Frontier is an all-in-one user management platform that provides identity, access and billing management to help organizations secure their systems and data. (Open source alternative to Clerk)

https://raystack-frontier.vercel.app/

Apache License 2.0

264 stars 34 forks source link

fix: billing account with no state in db were failing entitlement checks #647

Closed kushsharma closed 3 months ago

kushsharma commented 3 months ago

Billing account were not adding active state in db by default. We started adding active state later causing us to make the change backward compatible. This change while being made backward compatible used a where condition in db which although looked like it is using a AND between org and state filter, it was using an OR. The underlying library goqu didn't make it obvious to see from its methods.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
frontier	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 14, 2024 8:13am

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9512872754

Details

1 of 4 (25.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 9.411%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
billing/customer/service.go	0	3	0.0%
<!--	Total:	1	4	25.0%	-->

Totals
Change from base Build 9497576872:	0.02%
Covered Lines:	9912
Relevant Lines:	105324

raystack / frontier

fix: billing account with no state in db were failing entitlement checks #647

Pull Request Test Coverage Report for Build 9512872754

Details

💛 - Coveralls