fix: remove additional API call and fetch data from props

raystack / frontier

Frontier is an all-in-one user management platform that provides identity, access and billing management to help organizations secure their systems and data. (Open source alternative to Clerk)

https://raystack-frontier.vercel.app/

Apache License 2.0

273 stars 34 forks source link

fix: remove additional API call and fetch data from props #779

Closed paanSinghCoder closed 2 months ago

paanSinghCoder commented 2 months ago

IDE-520

Description: 1: On confirm-change popup open, the getPlan API was again being called which is unnecessary as current plan can simply be fetched from the allPlans prop already present in the component.

2: This effect hook was unnecessarily called. Need to confirm if removing this can have any side effects.

useEffect(() => {
    fetchActiveSubsciption();
}, [fetchActiveSubsciption]);

Testing Ongoing

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
frontier	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 20, 2024 9:33am

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10956825098

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 9.651%

Totals
Change from base Build 10953901096:	0.0%
Covered Lines:	10836
Relevant Lines:	112283

raystack / frontier

fix: remove additional API call and fetch data from props #779

Pull Request Test Coverage Report for Build 10956825098

Details

💛 - Coveralls