fix: while updating role, do full refresh of permissions

raystack / frontier

Frontier is an all-in-one user management platform that provides identity, access and billing management to help organizations secure their systems and data. (Open source alternative to Clerk)

https://raystack-frontier.vercel.app/

Apache License 2.0

273 stars 34 forks source link

fix: while updating role, do full refresh of permissions #812

Closed kushsharma closed 2 days ago

kushsharma commented 4 weeks ago

Currently while updating role, frontier used to identify the deleted permissions from role and only remove them which are needed. One problem with this is if in case someone manually modifies such roles and the permissions gets out of sync, it will not try to correct them. Now it deletes all existing permissions and create the new requested on every update call.

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
frontier	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 3:46pm

coveralls commented 4 weeks ago

Pull Request Test Coverage Report for Build 11707035493

Details

10 of 39 (25.64%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 30.849%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/api/v1beta1/billing_checkout.go	0	1	0.0%
internal/api/v1beta1/billing_customer.go	0	1	0.0%
core/role/service.go	0	27	0.0%
<!--	Total:	10	39	25.64%	-->

Totals
Change from base Build 11682366718:	0.02%
Covered Lines:	7628
Relevant Lines:	24727

raystack / frontier

fix: while updating role, do full refresh of permissions #812

Pull Request Test Coverage Report for Build 11707035493

Details

💛 - Coveralls