raystack / guardian

Guardian is universal data access management tool with automated access workflows and security controls across data stores, analytical systems, and cloud products.
https://guardian.vercel.app/
Apache License 2.0
137 stars 21 forks source link

Disable dockertest on repository test during unit test #354

Closed swallowstalker closed 1 year ago

swallowstalker commented 1 year ago

Summary

Our team has a problem when running unit test on CI, as the repository package test tries to access /var/run/docker.sock everytime we run make test. I think it is plausible to disable this during unit test since dockertest usage is intended for integration test.

Proposed solution

Additional context

For context, our team needs strong reason on why we should enable access to dockers and Guardian's dependencies during unit test, to change the CI configs

rahmatrhd commented 1 year ago

let's go with option 1. initially, we have unit tests in the repository package but we migrated to integration test since it gives more confidence and is simpler (don't have to write expected SQL), we don't want to go back to unit tests 🙂

swallowstalker commented 1 year ago

@rahmatrhd sure, i think i can create new PR for adding the short flag