raytracingDevTeam / raytracing

Raytracing source code from Shirley's Raytracing in One Weekend
MIT License
0 stars 0 forks source link

Command line parameters #33

Closed andrearastelli closed 6 years ago

andrearastelli commented 6 years ago

To simplify the execution of the application, and to avoid merge issues, we should provide of a way to set the input parameters through command line arguments.

This has to be done before releasing V1.0.0

andrearastelli commented 6 years ago

@Ale32 The command line arguments are now defined.

The functionality is not fully tested, so if something weird happen, has to be fixed.

The base parameter accepted for now are:

andrearastelli commented 6 years ago

Opened PR #34

Ale32 commented 6 years ago

I thought there was a standard way to do this, so it's better for us to use and mantain.

Do you think that this Boost.Program_options is too much for what we want to achieve?

andrearastelli commented 6 years ago

Is not too much, but require us to use boost. Do we want to use an external library?

I don't feel that we should focus on such features, right now.

We can always improve the way the command line arguments are parsed, so we can open a new issue referring that, but for the time being I think we should focus on raytracing features.

What do you think?

By the way, Boost will help with other stuff as well, but will add lots of dependencies that I'm not sure we want. For example, in PBRT, the solution to command line parameters was to write their own parser, so the raytracer has no external dependencies (except the very basic ones, like OpenEXR).

Ale32 commented 6 years ago

That's right, the less are the dependencies the better is.

andrearastelli commented 6 years ago

Will merge #34 tonight then