search

raywo / MMM-PublicTransportHafas

MMM-PublicTransportHafas is a module for the MagicMirror project by Michael Teeuw.
MIT License
30 stars 13 forks source link

Train operator changed ➡️ looks ugly #72

Open nixmeer opened 4 years ago

nixmeer commented 4 years ago

Hello :)

since January 1st, line "S3" of the "S-Bahn Rhein-Ruhr" is no longer being operated by the Deutsche Bahn but by Abellio which is a private train operator. It's still the same line "S3" but different trains and the DB API names them "ABR S3" (not only my mirror uses this name but also all smartphone apps I use).

This looks just ugly... is there any way to not just change the background color, border-radius etc. but also the displayed name?

Best

Jan

derhuerst commented 4 years ago

This is something that we should handle in the underlying library hafas-client; We already do this for e.g. the BVG endpoint and the SNCB endpoint.

nixmeer commented 4 years ago

That'd be great. I don't use it at the plug in right now but I am annoyed by all public transport apps writing "ABR RE6 (RRX)"... I don't care what kind of RE and who operates it. I just wanna know, if it's on time or not :D

derhuerst commented 4 years ago

Please open an Issue in the hafas-client repo. Let's collect more lines in Germany that have this kind of prefix.

[...] I am annoyed by all public transport apps writing "ABR RE6 (RRX)"... I don't care what kind of RE and who operates it. I just wanna know, if it's on time or not :D

Also, even if you were interested, that's what the operator field is for.

nixmeer commented 4 years ago

I’ll do that. Please add your insights about this module and the hafas-client.

What do you mean by operator field? Couldn’t find any here in this module, is it part of the hafas-client?

Edit: I just figured out the hafas-client is your repo 😃