rayxuln / spine-runtime-for-godot

This project is a module for godot that allows it to load/play Spine skeleton animation.
MIT License
93 stars 22 forks source link

Editor crashes when importing atlas #24

Open PhilipeFernandino opened 3 years ago

PhilipeFernandino commented 3 years ago

On 3.2.2-stable, the editor crashes when trying to import a .atlas file. Tried within several skeletons. Edit: When creating a new SpineAtlasResource resource too

rayxuln commented 3 years ago

Any additional log or information to help track this crash?

yuraj11 commented 3 years ago

@rayxuln I was able to replicate this issue and found what is causing this issue - .json and .atlas file must be in subdirectory res://something/(<.atlas/.json>) but not directly in root res://(<.atlas/.json>). Could you please take a look on this?

mk-5 commented 3 years ago

I've got the same issue -> and .atlas .json are not in the root folder. Godot is crashed every time I try to "select" or "drag" .atlas file.

godot-spine-crashed

Godot: the latest 3.2 branch Platform: windows Spine: the latest one

rayxuln commented 3 years ago

I've got the same issue -> and .atlas .json are not in the root folder. Godot is crashed every time I try to "select" or "drag" .atlas file.

godot-spine-crashed

Godot: the latest 3.2 branch Platform: windows Spine: the latest one

Did you put the .png file in the same folder? And it should print some error messages to the console. I'll be very appropriated if you could post them.

rayxuln commented 3 years ago

@rayxuln I was able to replicate this issue and found what is causing this issue - .json and .atlas file must be in subdirectory res://something/(<.atlas/.json>) but not directly in root res://(<.atlas/.json>). Could you please take a look on this?

It seems to be an issue and I've fixed it. It should be ok now if you put the atlas file in root, but please make sure to put the png file in the same directory as well.

mk-5 commented 3 years ago

@rayxuln

image

png file is there. Cannot get an error directly from Godot console, because it gets totally blocked and crashed. I've redirect logging to file, and this is what I got:

Godot Engine v3.2.4.beta.custom_build.5e4a8abe2 - https://godotengine.org
OpenGL ES 3.0 Renderer: AMD Radeon (TM) R9 200 Series

ERROR: Script does not inherit a Node: res://src/helpers.gd.
   At: editor\editor_autoload_settings.cpp:357
ERROR: get_multiple_md5: Condition "!f" is true. Continuing.
   At: core\os\file_access.cpp:667
ERROR: get_multiple_md5: Condition "!f" is true. Continuing.
   At: core\os\file_access.cpp:667
ERROR: _parse: ConfigFile parse error at [PATH]/state.gd-folding-e6de93d51b636f05d739d4b493be6085.cfg:2: Unexpected identifier: 'PackedStringArray'..
   At: core\io\config_file.cpp:296
ERROR: _parse: ConfigFile parse error at [PATH]/stick_physics.gd-folding-9cda32df406cf9b5eabdf2719edcbd25.cfg:2: Unexpected identifier: 'PackedStringArray'..
   At: core\io\config_file.cpp:296
ERROR: _parse: ConfigFile parse error at [PATH]/camera_shake.gd-folding-4700819e78acbc3e82846e03578095fd.cfg:2: Unexpected identifier: 'PackedStringArray'..
   At: core\io\config_file.cpp:296
ERROR: _parse: ConfigFile parse error at [PATH]/states_machine.gd-folding-e6bfe92f413ff0e28bcd1422012f0aa8.cfg:2: Unexpected identifier: 'PackedStringArray'..
   At: core\io\config_file.cpp:296
ERROR: _parse: ConfigFile parse error at [PATH]/stick.gd-folding-4cf5286703be2e080fa15c8c50e31f4b.cfg:2: Unexpected identifier: 'PackedStringArray'..
   At: core\io\config_file.cpp:296
ERROR: _parse: ConfigFile parse error at [PATH]/clouds.gd-folding-63a4e6f8fe9cf3d1288741682dd592c1.cfg:2: Unexpected identifier: 'PackedStringArray'..
   At: core\io\config_file.cpp:296
ERROR: _parse: ConfigFile parse error at [PATH]/score_board.gd-folding-65633136670ae059be950e90dfea754b.cfg:2: Unexpected identifier: 'PackedStringArray'..
   At: core\io\config_file.cpp:296
ERROR: _parse: ConfigFile parse error at [PATH]/zoom_sinusoid.gd-folding-e54679663dad0343a92a641e95da2242.cfg:2: Unexpected identifier: 'PackedStringArray'..
   At: core\io\config_file.cpp:296

Nothing else :/ as I said, the application is blocked and it crashes

rayxuln commented 3 years ago

So weird. I have no idea how to fixed this.

mk-5 commented 3 years ago

@rayxuln I will try to get some more info.

The one lead is that I've also built this https://github.com/GodotExplorer/spine module -> but it's not sufficient for me because there is no way to "bind" something to Spine slots. I saw that your implement has something called "BindSlots" this is why I'm trying to use it -> really thanks by the way for you library 🤜 🤛

I will try to remove this GodotExplorer/spine module, maybe something "overlapped crashed" :/

mk-5 commented 3 years ago

Okay, so it's getting weird. I removed GodotExplorer/spine. .atlas file is going to be imported successfully right now / but I've got the same crash situation while I'm trying to import the .json file.

Maybe I'm doing it in a wrong way, can I ask you to briefly explain how to load Spine into the project? In GodotExplorer/spine it was pretty straightforward

rayxuln commented 3 years ago

Okay, so it's getting weird. I removed GodotExplorer/spine. .atlas file is going to be imported successfully right now / but I've got the same crash situation while I'm trying to import the .json file.

Maybe I'm doing it in a wrong way, can I ask you to briefly explain how to load Spine into the project? In GodotExplorer/spine it was pretty straightforward

Just load atlas and json resources and it should be ok. Please try to run the demo project to test if it works well or not: https://github.com/rayxuln/Spine-Runtime-For-Godot-Example. Maybe it's because you are using the 3.2.4 beta version and I haven't tested on that yet.

mk-5 commented 3 years ago

@rayxuln no problem with the 3.2.4 version.

I found a reason 🙈🙈🙈 the skeleton has been exported via Spine 3.6.3. Updating it to 3.8.x solved the problem.

Thanks! :)