rayzrdev / SharpBot

A Discord.js selfbot written by Rayzr - 60 second installation!
https://git.io/sharpbot
MIT License
129 stars 134 forks source link

Es6 pointy functions #126

Closed ghost closed 6 years ago

ghost commented 6 years ago

Remove all instances of function and replace them with es6 pointy arrow functions.

rayzr522 commented 6 years ago

I mean, I suppose we could merge this, but why? What's wrong with having mixed functions/lambdas?

Side note: they're not "pointy arrow functions". They're lambdas.

ghost commented 6 years ago

Nothing wrong with them, just for consistency.

Den 24 nov. 2017 19:13 skrev "Rayzr" notifications@github.com:

I mean, I suppose we could merge this, but why? What's wrong with having mixed functions/lambdas?

Side note: they're not "pointy arrow functions". They're lambdas.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RayzrDev/SharpBot/pull/126#issuecomment-346878694, or mute the thread https://github.com/notifications/unsubscribe-auth/AfsluwRZe3TTlL1xfY-RWC3XEkBqLmxVks5s5wdTgaJpZM4QiGc4 .

rayzr522 commented 6 years ago

I suppose I'm fine with this. However, before I accept, I would prefer if all the single-variable lambdas had the parenthesis removed.

EDIT: That includes any async lambdas, so async single-variable lambdas should be in the form of async variable => { ... }

rayzr522 commented 6 years ago

Appears to be abandoned. I might as well just close this.