search

rayzrdev / SharpBot

A Discord.js selfbot written by Rayzr - 60 second installation!
https://git.io/sharpbot
MIT License
129 stars 134 forks source link

Better deleting #139

Closed eox closed 6 years ago

eox commented 6 years ago

Will now iterate through older posts to find posts. Previously, if the messages were older than the last 100 the commands failed.

Ideally tho, there should be a separate command that allows you to prune from messageid to message id. For example: .prune endmessageid startmessageid - this should fetch messages starting at endmessageid, then fetch 100 messages each until it encounters the startmessageid, effectively deleting all the messages in between.

but for now this is better than the current functionality

This is best achieved by taking the startmessageid and endmessageid from the user so u can prune the messages in between without iterating over or under. You simply keep iterating and receiving messages starting from the endmessageid until you reach the startmessageid.

the current functionality is quite garbage and limited as it only retrieves the last 100 messages in the channel and if your messages are further up, then it will ultimately fail.

i installed this bot because i had a need to prune all my messages on a server, thousands of messages that were deeply buried and the bot was useless. I had to adjust the functionality to make it work but of course it can be done better.

sure its not performance effective to have this functionality, but at the end of the day, if the user wants the functionality and does not care about the performance, the option needs to be available as it provides important utility. for example, i needed the functionality and was going to achieve it regardless and was forced to code it myself. other people could benefit from that too.

rayzr522 commented 6 years ago

You are aware that selfbots are no longer functional, right? E.g. no one is able to get their token anymore?

TortleWortle commented 6 years ago

What about the network tab authorisation header or did they change everything?

Invades commented 6 years ago

Pretty sure you still can though? Lol

eox commented 6 years ago

Yeah you can. I made it obvious to them on their discord. He was unaware of that method and made the post uninformed. The bot still works perfectly once you get your token.

rayzr522 commented 6 years ago

Yeah, I'm now aware of two methods that you can get your token still. But our official stance (as it now correctly says on the readme.md) is that we do not support selfbots.