razeghi71 / JalaliCalendar

Jalali Calendar for java
79 stars 25 forks source link

Wrong calcualtion from gregorian calendar #4

Closed javaherisaber closed 6 months ago

javaherisaber commented 5 years ago

Hi this library isn't working correctly consider gregorian calendar of this date = 2019-6-29 we expect JalaliCalendar to return 1398/04/08 but actually returns 1398/05/07

razeghi71 commented 5 years ago

Dear Mahdi, Thank you for your bug report, I will work on it this weekend.

TariRahil commented 3 years ago

Hi example 1: current date : gregorian = 2020-10-05 and jalali = 1399-07-14 but jalaliCalenda return 1399-07-15 that is wrong example 2: current date : gregorian = 2020-09-30 and jalali = 1399-07-09 and jalaliCalenda return 1399-07-09 that is OK

razeghi71 commented 7 months ago

@javaherisaber @TariRahil are you sure you're using the right 0 based Gregorian Calendar? if yes can you please paste here the snippet you're using?

mohammedhossyn commented 6 months ago

Hello dear Razeghi, thanks for sharing project. Actually they are right my friend, that returns a month after current month, G date: 2023-12-22 ---- P date: 1402-11-02

razeghi71 commented 6 months ago

do you take into account that:

First of all I should note that java gregorian calenders month is 0 base
razeghi71 commented 6 months ago

closing the issue as there is no response