search

razeware / emitron-Android

Android version of emitron
Apache License 2.0
55 stars 30 forks source link

Added window inset handling, sorted out the SettingsFragment scrolling behavior #286

Closed filbabic closed 4 years ago

filbabic commented 4 years ago

Fixed #281.

I added programmatic handling of Notches/Window insets to increase the top content padding, depending on the inset size. Now there is no more overlap with notches and the content.

I also changed up the layout in the Settings Fragment. It didn't make sense to me that the Toolbar and the back button were scrollable. I think it makes more sense to be fixed, as on smaller phones the user will scroll away the back button, and have to scroll back to go back (if they don't have SW/HW back buttons).

I'll add some images to show the behavior/changes.

filbabic commented 4 years ago

Screenshot_20200918-104325 Screenshot_20200918-105134 Screenshot_20200918-110635 Screenshot_20200918-110641

This is the image of the current behavior, except for the first image, which shows the previous behavior of the SettingsFragment.

You can't see the notch in the screenshots, as you can't take pictures of hardware (makes sense), but I can take a picture of my phone, to show the previous behavior if needed.