search

razeware / emitron-Android

Android version of emitron
Apache License 2.0
55 stars 30 forks source link

Settings: Move to its own tab #315

Closed luke-freeman closed 3 years ago

luke-freeman commented 3 years ago

Move settings to it's own tab in the navigation and remove it from the 'My Tutorials'. This will allow us to eventually add controls to My Tutorials to filter/remove all etc.

Expected behavior

Settings has it's own tab

Figma: https://www.figma.com/file/Sh3IyUBB0El4WiPamLNv4g/Emitron-Android?node-id=0%3A1243

Screenshot 2020-12-18 at 12 03 52

Actual behavior

Settings lives under My Tutorials

Environment

filbabic commented 3 years ago

Screenshot_1615978421 Screenshot_1615978423 Screenshot_1615978427

@luke-freeman How does this look? :]

filbabic commented 3 years ago

You'll probably notice that there are no titles for the icons unless the item is focused.

This is the default Android behavior and sadly it cannot be changed unless we use a third party hacked copy of the library and then add it.

But this would require of us to completely re-do the navigation we have currently, which is quite painful to do.

luke-freeman commented 3 years ago

@filbabic Lol that's crazy about the titles. It looks great!

filbabic commented 3 years ago

@luke-freeman Oh I actually did a bit more digging in the meantime and it seems there's been a change where that is now actually possible! :]

I'll add the labels then.

If the rest looks fine, I'll merge this once Rachit reviews the code!