razeware / emitron-Android

Android version of emitron
Apache License 2.0
55 stars 30 forks source link

Video Player (Portrait Mode) #318

Closed luke-freeman closed 3 years ago

luke-freeman commented 3 years ago

@filbabic

Is working on a portrait mode for the video player

Screenshot_1609751249 Screenshot_1609751256 Screenshot_1609751284 Screenshot_1609751271(1) Screenshot_1609751429(1)

luke-freeman commented 3 years ago

@filbabic

filbabic commented 3 years ago

Hey Luke!

filbabic commented 3 years ago

@luke-freeman I've done more work on the Portrait mode of the player feature, and this is the result: https://drive.google.com/drive/u/1/folders/1EKGD_Q0cwQxeaCNdFSYEIJQYoQRXolKj

As you can see, I've removed the text from the options, when in portrait mode. I changed the option orientation, so that now it works nicely, and the user can pick and choose their settings.

I've also fixed the centering of the title in the toolbar as the navigation button pushed it to the right side with padding.

Let me know if you feel like this is good enough UI to possibly prepare as a release in February. I can also build an APK and give it to you to test the feature if you'd like.

I'm aiming to implement this and ship it in February, to keep our releases going. I'll try to focus on mostly UI-related improvements in the next few months, so anything you feel is going to improve our experience will be prioritized.

I saw some tickets for changing the navigation, to have 4 tabs (current + settings) instead of three. This is also something I feel should be easy enough to change.