search

razeware / emitron-Android

Android version of emitron
Apache License 2.0
55 stars 30 forks source link

Update Room to Support M1 Macbooks #341

Closed jumaallan closed 1 year ago

jumaallan commented 2 years ago

Fixes Room Issue #340 when running the project on an M1 Mac

Some notes:

This might need to ship as is, since updating to the latest Room version means we need to target sdk 31. This introduces more changes which are out of scope for this PR

sammyd commented 2 years ago

@wangerekaharun could you take a look at this PR please, once you've got the updates you've been working on integrated? Thanks!

wangerekaharun commented 2 years ago

@wangerekaharun could you take a look at this PR please, once you've got the updates you've been working on integrated? Thanks!

@sammyd this can be merged, so that I can pull the changes.

sammyd commented 2 years ago

@jumaallan thanks so much for this. Sadly, I've just merged a pretty big PR to address a login issue to development, and there are now some conflicts. Would you be able to resolve these conflicts and ask for another review please? Thanks!

jumaallan commented 2 years ago

@sammyd I have fixed the small conflicts. Should be ready for review again

jumaallan commented 2 years ago

@sammyd / @wangerekaharun Ping

The CI failure is related to keystore config missing. You can take a look at this @wangerekaharun

wangerekaharun commented 2 years ago

I'll look into this @jumaallan also you can pull the development branch since I raised a PR and CI was not failing.