Copying a quest record causes extraneous script fragment data to be generated.

raziel23x / skyrim-plugin-decoding-project

Automatically exported from code.google.com/p/skyrim-plugin-decoding-project

1 stars 3 forks source link

Copying a quest record causes extraneous script fragment data to be generated. #107

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Load the attached file
2. Copy as override either of the quest records into a new file (or an 
existing, like I was)
3. Observe the results.

What is the expected output?
The record should copy without the red parts.

What do you see instead?
Extra data that isn't desired is being inserted.

Please provide any additional information below.
Image attached.

Original issue reported on code.google.com by arthmoor on 11 Feb 2013 at 12:07

Attachments:

[Bug 9959 Fix.esp](https://storage.googleapis.com/google-code-attachments/skyrim-plugin-decoding-project/issue-107/comment-0/Bug 9959 Fix.esp)
badquestcopy.jpg

GoogleCodeExporter commented 9 years ago

I noticed that before, and checked copied record in CK. Didn't notice any 
differences from vanilla. So, does it affect anything in game/CK?

Original comment by zila...@gmail.com on 11 Feb 2013 at 12:28

GoogleCodeExporter commented 9 years ago

I don't know. I declined to save the results and went and made the changes 
manually in the CK instead.

I'm not comfortable with the idea of accepting junk data like this. Plus, it 
wasn't happening prior to the public release as far as I can remember.

The CK doesn't generate the extra garbage data when it saves a record, so I 
don't see why xEdit should be generating it either.

Original comment by arthmoor on 11 Feb 2013 at 12:39

GoogleCodeExporter commented 9 years ago

It was happening prior to release too.
I agree that it is a junk, but it doesn't affect game/CK, and resaving plugin 
in CK removes it. I'd like it not to be added in the first place, but not sure 
if it is possible. All that vmad handling code in tricky.

Original comment by zila...@gmail.com on 11 Feb 2013 at 1:11

GoogleCodeExporter commented 9 years ago

The main issue is that some 0 length array are stored like the properties, and 
others are not like this one. I'll look to see if I can intercept it during 
copy.

Original comment by HuguesLe...@gmail.com on 11 Feb 2013 at 7:04

Changed state: Started

GoogleCodeExporter commented 9 years ago

Found where and why. It was a genuine bug dating back to at least 3.0.10: A 
struct containing integers or anything with a fixed size would never have a 
zero size even if it was not present!

Original comment by HuguesLe...@gmail.com on 11 Feb 2013 at 10:52

GoogleCodeExporter commented 9 years ago

Fix uploaded as r1198

Original comment by HuguesLe...@gmail.com on 11 Feb 2013 at 11:36

GoogleCodeExporter commented 9 years ago

Present from Elminster I guess :)

Original comment by zila...@gmail.com on 12 Feb 2013 at 6:12

GoogleCodeExporter commented 9 years ago

Original comment by zila...@gmail.com on 15 Feb 2013 at 5:55

Changed state: Fixed