A new condition with empty fields when adding

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Add a new CTDA subrecord condition in any record with conditions, I tested 
on PERK.

What is the expected output?
A new condition with zero/default value fields

What do you see instead?
A new condition with empty (literally) fields, see screenshot.

What version of the product are you using? On what operating system?
3.0.29

Please provide any additional information below.
This is probably tied to the fix of not adding garbage zero data in VMAD when 
copying scripts, but I'd rather have a garbage there instead of this. A pair of 
zero bytes in VMAD doesn't affect game or CK, but this can potentially ruin 
plugin's integrity and cause problems.

Original issue reported on code.google.com by zila...@gmail.com on 9 Mar 2013 at 10:54

Attachments:

• empty_ctda.png

[GoogleCodeExporter]

A) Creating specific SetToDefault for each TwbValueDef corrects that.

B) I found an "interesting" visual bug on Perk copy as override. CTDA inside 
PERK effects can be totally screwed, but saving and reloading show the data is 
correct.

Original comment by HuguesLe...@gmail.com on 9 Mar 2013 at 3:12

Attachments:

• ScrewedPerk.PNG

[GoogleCodeExporter]

Its an old thing when compared arrays are not sorted, like CTDA. They are not 
screwed, just not aligned against each other because sorting order is random I 
guess?

Original comment by zila...@gmail.com on 9 Mar 2013 at 4:06

[GoogleCodeExporter]

seems like sorting order has always been random in Perks, even in previous 
games - an override won't match up in xEdit. When opening/editing the perk in 
the Geck, the order of perk entries will scramble - so trying to fix it 
visually for xEdit might not be worth the effort :) Doesn't seem to harm 
anything, but when manipulating perks in xEdit, it's a pain to try and just 
drag one field over - you have to drag the whole section, which really isn't a 
big deal.

Original comment by rickerhk...@gmail.com on 9 Mar 2013 at 4:26

[GoogleCodeExporter]

I know there is an issue with CTDA displays in xEdit, but here I swear there 
was values that were "randomly" changed in the unknowns.

Only way to fix that is :
A) do not sort CTDA arrays, so 
B) make a SortKey for such array which is equal to the hexadecimal dump of the 
array.
Could not make that work for the limited time I invested in that.

Anyway the main issue is fixed in r1259.
I verified Copy as new and Copy as overide for side effect.

Original comment by HuguesLe...@gmail.com on 9 Mar 2013 at 4:38

• Changed state: Fixed

[GoogleCodeExporter]

CTDAs are unsorted since their order does matter.
I think it is Perk effects, they are sorted but sort keys are unreliable, there 
are just no values that can give an unique sort key for each effect. So every 
time you edit something there, they jump around (since FO3Edit).
If you look closer at record 00079AF5, there are several effects that have 
similar conditions, so you got a feeling that there is a problem with CTDAs. 
But the real cause is the whole effects section that is not aligned.
Anyway, I don't think it is a bug and needs any fixing, because this is the 
only place where sorting is unreliable.

Original comment by zila...@gmail.com on 9 Mar 2013 at 5:27