raziel23x / skyrim-plugin-decoding-project

Automatically exported from code.google.com/p/skyrim-plugin-decoding-project
1 stars 3 forks source link

[Skyrim] Clean Masters should not remove Update.esm #175

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Load any mod up with Skyrim.esm and Update.esm as masters.
2. Run Clean Masters on the file.

What is the expected output?
Update.esm should not be removed.

What do you see instead?
Update.esm is removed from the mod if no 01 forms are referenced.

While this seems like the thing to do because technically nothing native to 
Update.esm may be used, it shouldn't be done. Modders are specifically 
attaching Update.esm in order to avoid stepping on official fixes.

Removing Update.esm exposes them to the future possibility of overwriting a 
vanilla form that the official patches already fixed.

Clean Masters should simply never remove Update.esm when it's encountered for 
Skyrim mods.

Original issue reported on code.google.com by arthmoor on 29 Oct 2014 at 10:36

GoogleCodeExporter commented 9 years ago
Not sure about it. Technically update.esm is just another plugin and removing 
it from master if not referenced doesn't break anything. Also taking in account 
the CK limitation of 2 master for another esm, removing Update.esm is actually 
beneficial when possible.
Those are cons of not removing. What are the pros except "avoid stepping on 
official fixes"?

Original comment by zila...@gmail.com on 30 Oct 2014 at 2:37

GoogleCodeExporter commented 9 years ago
The CK limitation is easily overcome by enabling multiple masters - and pretty 
much anyone truly serious about modding did that the day the DLCs came out and 
force that to be necessary anyway.

Also, removing Update.esm from a mod that uses a DLC as a master would only 
result in the CK reverting the change again later since the DLCs require it 
anyway.

I would think that avoiding the possibility of stepping on an official fix is 
reason enough to prevent it from being removed from a mod that's using it.

Original comment by arthmoor on 30 Oct 2014 at 7:22