search

raziel23x / skyrim-plugin-decoding-project

Automatically exported from code.google.com/p/skyrim-plugin-decoding-project
1 stars 3 forks source link

Error copying array of fixed length strings #184

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
Copy as override any MGEF record with counter effects, for example ABAT "Absorb 
Attribute" [MGEF:000008C9]

What is the expected output?
ITM counter effects

What do you see instead?
Extra element with wrong size

What version of the product are you using? On what operating system?
r1866

Please provide any additional information below.
Tried to replace ESCE definition with
wbArray(ESCE, 'Counter Effects', wbString('Counter Effect Code', 4))
Still doesn't work. However arrays of dynamic length strings work fine, for 
example NIFZ models in CREA record.

Original issue reported on code.google.com by zila...@gmail.com on 5 Jan 2015 at 1:35

GoogleCodeExporter commented 9 years ago 
Do you know what the TwbStringListTerminator is for ? That is what is added by 
CheckTerminator and, unfortunately, becomes visible.

Original comment by HuguesLe...@gmail.com on 7 Jan 2015 at 2:21

GoogleCodeExporter commented 9 years ago 
I can only guess that Elminster hardcoded it for NIFZ models list where it is 
required. I think this is the only place where array of strings is actually 
used in all of the games. Turned out there is another place with counter 
effects, and as they use fixed length strings, I think adding a check for fixed 
length strings somewhere in TwbSubrecord.CheckTerminator and skip creating 
TwbStringListTerminator should work.

Original comment by zila...@gmail.com on 7 Jan 2015 at 7:44

GoogleCodeExporter commented 9 years ago 
Can you check now with an older release like 3.0.10 ? If not, I'll try later 
from home.

Original comment by HuguesLe...@gmail.com on 7 Jan 2015 at 8:38

GoogleCodeExporter commented 9 years ago 
Anyway, detecting fixed size strings works.

Original comment by HuguesLe...@gmail.com on 7 Jan 2015 at 1:38

GoogleCodeExporter commented 9 years ago 
see r1867

Original comment by HuguesLe...@gmail.com on 7 Jan 2015 at 7:11

GoogleCodeExporter commented 9 years ago

Original comment by HuguesLe...@gmail.com on 7 Jan 2015 at 10:19

GoogleCodeExporter commented 9 years ago 
Fixed in r1867

Original comment by zila...@gmail.com on 16 Jan 2015 at 6:33