raziel23x / skyrim-plugin-decoding-project

Automatically exported from code.google.com/p/skyrim-plugin-decoding-project
1 stars 3 forks source link

Game Specific references. #40

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What needs to be reviewed?

Remove all game specific references such a Fallout or Oblivion.

Describe how it is now.

From MainView.Spells.cs

bool firstwasfallout = false;
                if (r != null && r.Name == "TES4")
                {
                    foreach (SubRecord sr in r.SubRecords)
                    {
                        if (sr.Name == "MAST")
                        {
                            if (sr.GetStrData().ToLowerInvariant() == "skyrim.esm")
                            {
                                firstwasfallout = true;
                            }

                            break;
                        }
                    }
                }

                if (!firstwasfallout)
                {
                    MessageBox.Show("Only works on plugin's whose first master is Skyrim.esm", "Error");
                    return;

Describe the desired change.

make references generic to make way for making Snip work with Morrowind, 
Oblivion, and Skyrim.

Outline the goals/benefits of the enhancement.

Please provide any additional information below.

Original issue reported on code.google.com by danielhmpdx16@gmail.com on 20 Aug 2012 at 3:20

GoogleCodeExporter commented 9 years ago

Original comment by danielhmpdx16@gmail.com on 22 Sep 2012 at 11:40