search

razonyang / hugo-theme-bootstrap

A fast, responsive, multipurpose and feature-rich Hugo theme.
https://hbs.razonyang.com
MIT License
507 stars 166 forks source link

update github pages workflow from planned deprecation of v3 to v4 #1038

Closed liluzibird closed 6 months ago

liluzibird commented 6 months ago
netlify[bot] commented 6 months ago

Deploy Preview for hbs-docs failed.

Name Link
Latest commit 0bb25fc20b42c12bbec275cd2c1f10e49c0e8fa5
Latest deploy log https://app.netlify.com/sites/hbs-docs/deploys/6632d09273275f000837343c
liluzibird commented 6 months ago

whaat why fail

liluzibird commented 6 months ago

bro wth

liluzibird commented 6 months ago

I just want to update the github pages deployment code, it can't be that hard wth

liluzibird commented 6 months ago

uploading the exact same code to see if it's not my problem

liluzibird commented 6 months ago

Alright I guess it's my changes

liluzibird commented 6 months ago

guess I'll figure out what I'm doing wrong later

razonyang commented 6 months ago

whaat why fail

That's because that it's a not a good idea to save code block inside a shortcode, since Hugo will execute it as a template, in this case {{ runner* }} will be treated as a Hugo function or variable, and then throw an error.

I've renamed it to be a page resource, update the exampleSite/content/docs/deployment/github-pages/code/workflow will work.

Thanks for your contributions.

liluzibird commented 6 months ago

Ah ok, can't believe I didn't figure that out. I was so confused where to put the code I didn't even check that it was supposed to be in /docs/deployment/github-pages/code/workflow.

razonyang commented 6 months ago

I was so confused where to put the code I didn't even check that it was supposed to be in /docs/deployment/github-pages/code/workflow.

You have modified the correct file, but the original file is not a good idea, and I created that file a few hours ago. But I didn't change the workflow, please open another PR if you're still want to contribute.