search

razonyang / hugo-theme-bootstrap

A fast, responsive, multipurpose and feature-rich Hugo theme.
https://hbs.razonyang.com
MIT License
495 stars 169 forks source link

User intractable toggle to hide/show the content only (hiding the sidebar) #115

Closed sudipghimire533 closed 3 years ago

sudipghimire533 commented 3 years ago

It would be wiser to put a toggling button somewhere on the top right corner (not in navbar) near post title to achive something like this image

I also realized that putting that button anywhere on home page would steal current look but adding that on the post page would be plus point.

sudipghimire533 commented 3 years ago

Reading on maximum width on https://hugo-theme-bootstrap.netlify.app/ was more good btw. So I have to scroll less and it would be no trouble for people who wants to see just the content while reading

razonyang commented 3 years ago

Implemented in 195ebb5a7eb7251c5be1fc3ca8a11e274b305d8e. Please upgrade the theme to the latest version(v0.28.0) or the latest commit.

sudipghimire533 commented 3 years ago

Is that really the intended position of the fullscreen button as well as TOC button? Or is this just happening on mine image I really wish I could help you on this but currently I can't

razonyang commented 3 years ago

Yep, that's intended. Any suggestions are welcome.

sudipghimire533 commented 3 years ago

Buddy! I think this one was your first miss. That's seems disturbing (I got same feedback from couple of my mates). TOC button placement was just perfect before. And thing about expand button may somwhere as in below image image And we may also change icon of expanding button accordingly (if current state is expanded or not) or using the icon like this may be wise image

also persisting between session for expanded state (Same way you did fabulous job to persist color palette, and dark theme toggling) and Also what about not expanding the panel by deafult on device with smaller width (this is not that much of importance though)?

I am just another guy explaining what I think would be clean. feel free to correct me. At the same time I am also trying to praise you and not pressurize :wink:

razonyang commented 3 years ago

LGTM, I'll try to implement it. Thanks for your suggestions.

razonyang commented 3 years ago

Reopen it until it's done~

razonyang commented 3 years ago

@sudipghimire533 Done. You can see the change in https://hugo-theme-bootstrap.netlify.app/en/posts/markdown-syntax now.

I'm looking forward to your feedback. I'll draft a new release after closing it.

sudipghimire533 commented 3 years ago

Peerfect. Does there a icon that have same effect as transfrom: rotateZ(-45deg) And I guess persist is yet to implements

sudipghimire533 commented 3 years ago

And what about hiding those sidbar by default in small screen?

razonyang commented 3 years ago

And what about hiding those sidbar by default in small screen?

image

I don't think it's going to affect the reading in the small screen. And I'm worried that hiding the sidebar will affect the search engine index.

razonyang commented 3 years ago

Does there a icon that have same effect as transfrom: rotateZ(-45deg)

I didn't get it. Could you please explain it in detail?

And I guess persist is yet to implements

I think it's implemented, the behavior(hide/show sidebar) was stored in LocalStorage.

sudipghimire533 commented 3 years ago

Does there a icon that have same effect as transfrom: rotateZ(-45deg) I didn't get it. Could you please explain it in detail? I mean to use the icon like that but tilted by -45deg. Just asking such icon available to use. Btw Everything looks good now. Didn't knew such thing about SEO. But ofcourse we should prioritize search engine. If hiding sidbar by default on smaller screen is to be worried with search engine then we better of not do that then

razonyang commented 3 years ago

Thanks for your suggestions and cooperation. I drafted a new release(v0.29.0) for that changes.